Update release to build darwin/arm64 binary #5286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We currently build with cgo to enable the fast notify trigger. But
dockercore/golang-cross has too old a toolchain to enable CGO for
darwin/arm64. So for darwin/arm64 we disable CGO and use notify's
kqueue support instead.
- Tweak the Makefile variables to allow specifying the Go version,
build tags, and CGO_ENABLED on a per os/arch basis. Reorganize
the variables on a per os/arch basis.
- Use github.com/randall77/makefat to build a multi-arch ("fat")
binary for Darwin for those that want it.
Codecov Report
@@ Coverage Diff @@
## master #5286 +/- ##
=======================================
Coverage 71.84% 71.84%
=======================================
Files 392 392
Lines 14219 14219
=======================================
Hits 10215 10215
Misses 3256 3256
Partials 748 748 Continue to review full report at Codecov.
|
IsaacPD
reviewed
Jan 25, 2021
|
Converting this to a draft as I'm not entirely sure if it's worth undertaking a stop-gap measure vs just doing the right thing in the first place. |
|
Converting this from draft: although using a CGO-less build is a stop-gap measure, it gets a native binary out. A perfect solution can be brought in with #2154. |
IsaacPD
approved these changes
Feb 3, 2021
briandealwis
added a commit
that referenced
this pull request
Feb 8, 2021
We normally build with cgo to enable the fast notify trigger. But dockercore/golang-cross has too old a toolchain to enable CGO for darwin/arm64. So for darwin/arm64, disable CGO and use notify's kqueue support instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #5042
We currently build with cgo to enable the fast notify trigger. But
dockercore/golang-crosshas too old a toolchain to enable cgo for darwin/arm64. So for darwin/arm64 we disable cgo and use notify's kqueue support instead.This is a stop-gap measure since we need to produce signed binaries anyways (#2154).
This PR:
kqueue(Fix Darwin build without Cgo rjeczalik/notify#182) and also to pull in bug fixes that are not yet in a release.